hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun C Murthy (JIRA)" <j...@apache.org>
Subject [jira] Created: (HADOOP-2726) Remove dead code block in JobInProgress.completedTask
Date Tue, 29 Jan 2008 04:42:34 GMT
Remove dead code block in  JobInProgress.completedTask
------------------------------------------------------

                 Key: HADOOP-2726
                 URL: https://issues.apache.org/jira/browse/HADOOP-2726
             Project: Hadoop Core
          Issue Type: Improvement
    Affects Versions: 0.15.0
            Reporter: Arun C Murthy
             Fix For: 0.17.0


Since the taskCommitThread ensures that one and only one task of a given TIP is marked as
SUCCEEDED, we don't need the code block in JobInProgress.completedTask which checks if the
TIP is complete and then just marks the task as complete:

{noformat}
    // Sanity check: is the TIP already complete? 
    if (tip.isComplete()) {
      // Mark this task as KILLED
      tip.alreadyCompletedTask(taskid);

      // Let the JobTracker cleanup this taskid if the job isn't running
      if (this.status.getRunState() != JobStatus.RUNNING) {
        jobtracker.markCompletedTaskAttempt(status.getTaskTracker(), taskid);
      }
      return false;
    } 
{noformat}


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message