hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (HADOOP-2385) Validate configuration parameters
Date Tue, 15 Jan 2008 00:44:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558880#action_12558880
] 

shv edited comment on HADOOP-2385 at 1/14/08 4:44 PM:
----------------------------------------------------------------------

I agree, visibility of accessors should depend on whether they are used publicly or internally.
Say getters for parameters used only in FSNamesystem should be package private.
Some getters may be public, but the corresponding setters may not.

> find the most-specific public class that encompasses the use and add the accessor there.

I would prefer creating new classes solely dedicated to configuration logic rather then including
implementation of accessors in existing public classes. Imo this makes a better structured
code.


      was (Author: shv):
    I agree, visibility of accessors should depend on whether they are used publicly or internally.
Say getters for parameters used only in FSNamesystem should package private.
Some getters may be public, but the corresponding setters may not.

> find the most-specific public class that encompasses the use and add the accessor there.

I would prefer creating new classes solely dedicated to configuration logic rather then including
implementation of accessors in existing public classes. Imo this makes a better structured
code.

  
> Validate configuration parameters
> ---------------------------------
>
>                 Key: HADOOP-2385
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2385
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>
> Configuration parameters should be fully validated before name nodes or data nodes begin
service.
> Required parameters must be present.
> Required and optional parameters must have values of proper type and range.
> Undefined parameters must not be present.
> (I was recently observing some confusion whose root cause was a mis-spelled parameter.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message