hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2553) [hbase] Don't make Long objects calculating hbase type hash codes
Date Thu, 10 Jan 2008 06:53:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557558#action_12557558
] 

Hadoop QA commented on HADOOP-2553:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12372747/white-v2.patch
against trunk revision r610648.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1535/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1535/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1535/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1535/console

This message is automatically generated.

> [hbase] Don't make Long objects calculating hbase type hash codes
> -----------------------------------------------------------------
>
>                 Key: HADOOP-2553
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2553
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>            Reporter: stack
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: white-v2.patch, white.patch
>
>
> From a code perusal by Tom White:
> {code}
> ...
> 1. In Memcache.internalGet the following line doesn't seem to do anything.
> curKey.setVersion(itKey.getTimestamp() - 1);
> So why have curKey at all? Am I missing something?
> 2. Hashcode for HStoreKey (and others) uses the form Long.valueOf(...)
> for long fields. This creates an object each time - not sure if it's a
> problem (probably isn't) but as you've been doing some profiling I
> thought I'd mention it.
> ...
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message