hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2528) check permissions for job inputs and outputs
Date Fri, 04 Jan 2008 23:42:33 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556119#action_12556119
] 

Doug Cutting commented on HADOOP-2528:
--------------------------------------

> What if permissions checking is disabled (trunk currently allows it. it is in fact the
default)?

Yes, it is possible to disable HDFS permission checks.  But shouldn't generic permission checking
code still work?  We don't want every bit of code that uses filesystem permissions to first
have to check if permission checking is enabled.  Rather, generic permission checking code
should be a no-op when permission checking is disabled in a particular filesystem implementation.

> This looks similar to how DFS used to invoke 'exits(file)' before opening a file.

Again, this patch causes no new HDFS RPC calls to be made.  It just checks the new values
now returned.  You might argue that we should disable all input and output checks, but that
should be done in a separate issue.  Input and output checking were added since folks preferred
to find out sooner when their jobs were destined to fail.  Perhaps with splits generated client-side
now input checking is less critical.  But checking the output directory is probably still
of great value.

> I don't think client alone can decide if a particular access is allowed.

The value of FileStatus.getPermission() is never null.  It should either be "777" or the correct
value for filesystems that implement permission checking.

> check permissions for job inputs and outputs
> --------------------------------------------
>
>                 Key: HADOOP-2528
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2528
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Doug Cutting
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2528-0.patch
>
>
> On job submission, filesystem permissions should be checked to ensure that the input
directory is readable and that the output directory is writable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message