hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nigel Daley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2566) need FileSystem#globStatus method
Date Fri, 25 Jan 2008 19:05:35 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562623#action_12562623
] 

Nigel Daley commented on HADOOP-2566:
-------------------------------------

+1.  fix looks good.  I also ran these tests against http://issues.apache.org/jira/secure/attachment/12374010/globStatus9.patch

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac -1.  The applied patch generated 607 javac compiler warnings (more than the trunk's
current 585 warnings).

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

The additional javac warnings are expected since this patch deprecates a couple of methods.

Hairong, once you run "ant test" on your own machine with no failures, please commit this.

> need FileSystem#globStatus method
> ---------------------------------
>
>                 Key: HADOOP-2566
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2566
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.15.2
>            Reporter: Doug Cutting
>            Assignee: Hairong Kuang
>             Fix For: 0.16.0
>
>         Attachments: globStatus.patch, globStatus1.patch, globStatus2.patch, globStatus3.patch,
globStatus4.patch, globStatus5.patch, globStatus6.patch, globStatus7.patch, globStatus8.patch,
globStatus9.patch
>
>
> To remove the cache of FileStatus in DFSPath (HADOOP-2565) without hurting performance,
we must use file enumeration APIs that return FileStatus[] rather than Path[].  Currently
we have FileSystem#globPaths(), but that method should be deprecated and replaced with a FileSystem#globStatus().
> We need to deprecate FileSystem#globPaths() in 0.16 in order to remove the cache in 0.17.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message