hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nigel Daley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2509) Some source files are missing license headers
Date Tue, 15 Jan 2008 06:33:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558936#action_12558936
] 

Nigel Daley commented on HADOOP-2509:
-------------------------------------

Looks like a good start.  A couple suggestions:

 # just have 1 target called 'rat' (it does more than just headers)
 # require the user to download the library (so they get the latest one)
 # add a check for the rat*.jar library before executing the target and fail gracefully
 # perhaps set failonerror (or errorproperty?) so the build will (or can) fail if the rat
report indicates an error (provided rat exits with non-zero on error)

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message