Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 72658 invoked from network); 6 Dec 2007 12:28:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Dec 2007 12:28:15 -0000 Received: (qmail 4813 invoked by uid 500); 6 Dec 2007 12:28:02 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 4787 invoked by uid 500); 6 Dec 2007 12:28:02 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 4778 invoked by uid 99); 6 Dec 2007 12:28:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Dec 2007 04:28:02 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Dec 2007 12:28:04 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 108E7714240 for ; Thu, 6 Dec 2007 04:27:43 -0800 (PST) Message-ID: <31388381.1196944063064.JavaMail.jira@brutus> Date: Thu, 6 Dec 2007 04:27:43 -0800 (PST) From: "Adrian Woodhead (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Updated: (HADOOP-2268) JobControl classes should use interfaces rather than implemenations In-Reply-To: <4207510.1195815463227.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Woodhead updated HADOOP-2268: ------------------------------------ Status: Patch Available (was: Open) Let's see what Hudson thinks of this patch... > JobControl classes should use interfaces rather than implemenations > ------------------------------------------------------------------- > > Key: HADOOP-2268 > URL: https://issues.apache.org/jira/browse/HADOOP-2268 > Project: Hadoop > Issue Type: Improvement > Components: mapred > Affects Versions: 0.15.0 > Reporter: Adrian Woodhead > Assignee: Adrian Woodhead > Priority: Minor > Fix For: 0.16.0 > > Attachments: HADOOP-2268-1.patch, HADOOP-2268-2.patch, HADOOP-2268-3.patch > > > See HADOOP-2202 for background on this issue. Arun C. Murthy agrees that when possible it is preferable to program against the interface rather than a concrete implementation (more flexible, allows for changes of the implementation in future etc.) JobControl currently exposes running, waiting, ready, successful and dependent jobs as ArrayList rather than List. I propose to change this to List. > I will code up a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.