Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 47803 invoked from network); 20 Dec 2007 18:45:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 20 Dec 2007 18:45:10 -0000 Received: (qmail 53278 invoked by uid 500); 20 Dec 2007 18:44:56 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 53227 invoked by uid 500); 20 Dec 2007 18:44:55 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 53206 invoked by uid 99); 20 Dec 2007 18:44:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Dec 2007 10:44:55 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Dec 2007 18:44:52 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 5EFCD71420A for ; Thu, 20 Dec 2007 10:44:43 -0800 (PST) Message-ID: <29720198.1198176283386.JavaMail.jira@brutus> Date: Thu, 20 Dec 2007 10:44:43 -0800 (PST) From: "stack (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Commented: (HADOOP-2291) [hbase] Add row count estimator In-Reply-To: <26877560.1196188963294.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553744 ] stack commented on HADOOP-2291: ------------------------------- What is state of this issue Edward? Will it not work on billions of rows? Other comments on the patch are: + We should add a HTable.getTableDescriptor and a HTable.getColumnFamilies? + Comments would be helpful. For example would be good to explain why you of a sudden set a variable 'i' equal to 2 and a comment confirming what you are doing finding midkeys over and over again would be helpful (Won't this take a long time on a big table)? + If in your search for endKey turns up a null, won't you get a NPE when you convert back from base64? + Would suggest that the estimator or an estimator override take as inputs the smallest slice to start with and the largest slice that the estimator should try. > [hbase] Add row count estimator > ------------------------------- > > Key: HADOOP-2291 > URL: https://issues.apache.org/jira/browse/HADOOP-2291 > Project: Hadoop > Issue Type: New Feature > Components: contrib/hbase > Reporter: stack > Assignee: Edward Yoon > Priority: Minor > Attachments: 2291_v01.patch, Keying.java > > > Internally we have a little tool that will do a rough estimate of how many rows there are in a dataHbase. It keeps getting larger and larger partitions running scanners until it turns up > N occupied rows. Once it has a number > N, it multiples by the partition size to get an approximate row count. > This issue is about generalizing this feature so it could sit in the general hbase install. It would look something like: > {code} > long getApproximateRowCount(final Text startRow, final Text endRow, final long minimumCountPerPartition, final long maximumPartitionSize) > {code} > Larger minimumCountPerPartition and maximumPartitionSize values would make the count more accurate but would mean the method ran longer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.