Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 51084 invoked from network); 27 Dec 2007 04:33:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Dec 2007 04:33:08 -0000 Received: (qmail 56102 invoked by uid 500); 27 Dec 2007 04:32:56 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 56068 invoked by uid 500); 27 Dec 2007 04:32:56 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 56059 invoked by uid 99); 27 Dec 2007 04:32:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Dec 2007 20:32:56 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Dec 2007 04:32:52 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id BE238714231 for ; Wed, 26 Dec 2007 20:32:43 -0800 (PST) Message-ID: <24139375.1198729963776.JavaMail.jira@brutus> Date: Wed, 26 Dec 2007 20:32:43 -0800 (PST) From: "Amar Kamat (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Commented: (HADOOP-2284) BasicTypeSorterBase.compare calls progress on each compare In-Reply-To: <4407269.1196114683342.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554515 ] Amar Kamat commented on HADOOP-2284: ------------------------------------ Yeah. It should be some fraction of {{mapred.task.timeout}}. I was thinking like *2%*. So that we make sure that sufficient attempts are made to declare the progress (in this case 50 attempts) and 50 progress indications while sorting should not be a problem. no? > BasicTypeSorterBase.compare calls progress on each compare > ---------------------------------------------------------- > > Key: HADOOP-2284 > URL: https://issues.apache.org/jira/browse/HADOOP-2284 > Project: Hadoop > Issue Type: Bug > Components: mapred > Reporter: Owen O'Malley > Assignee: Devaraj Das > Fix For: 0.16.0 > > > The inner loop of the sort is calling progress on each compare. I think it would make more sense to call progress in the sort rather than the compare or at most every 10000 compares. In the performance numbers, the call to progress as part of the sort are consuming 12% of the total cpu time when running word count under the local runner. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.