hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2323) JobTracker.close() prints stack traces for exceptions that are not errors
Date Sat, 01 Dec 2007 01:54:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547362

Hadoop QA commented on HADOOP-2323:

+1 overall.  Here are the results of testing the latest attachment 
against trunk revision r599951.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1223/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1223/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1223/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1223/console

This message is automatically generated.

> JobTracker.close() prints stack traces for exceptions that are not errors
> -------------------------------------------------------------------------
>                 Key: HADOOP-2323
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2323
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Jim Kellerman
>            Assignee: Jim Kellerman
>             Fix For: 0.16.0
>         Attachments: patch.txt
> JobTracker.close() prints a stack trace for an interrupted exception even though it was
the method that interrupted the thread that threw the exception. For example:
> {code}
>       this.expireTrackers.stopTracker();
>       try {
>         this.expireTrackersThread.interrupt();
>         this.expireTrackersThread.join();
>       } catch (InterruptedException ex) {
>         ex.printStackTrace();
>       }
> {code}
> Well of course it is going to catch an InterruptedException after it just interrupted
the thread!
> This is *not* an error and should  *not* be dumped to the logs!
> In other circumstances, catching InterruptedException is entirely appropriate. Just not
in close where you've told the thread to shutdown and then interrupted it to ensure it does!

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message