hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj Das (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2284) BasicTypeSorterBase.compare calls progress on each compare
Date Thu, 27 Dec 2007 05:49:43 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554527
] 

Devaraj Das commented on HADOOP-2284:
-------------------------------------

I am worried about the time based approach since it might end up making a native call, system.currentTimeMillis()
on every compare. 

> BasicTypeSorterBase.compare calls progress on each compare
> ----------------------------------------------------------
>
>                 Key: HADOOP-2284
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2284
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Owen O'Malley
>            Assignee: Devaraj Das
>             Fix For: 0.16.0
>
>
> The inner loop of the sort is calling progress on each compare. I think it would make
more sense to call progress in the sort rather than the compare or at most every 10000 compares.
In the performance numbers, the call to progress as part of the sort are consuming 12% of
the total cpu time when running word count under the local runner.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message