Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hadoop-dev@lucene.apache.org
Message-ID: <20220010.1196191423486.JavaMail.jira@brutus>
Date: Tue, 27 Nov 2007 11:23:43 -0800 (PST)
From: "Jim Kellerman (JIRA)" <jira@apache.org>
To: hadoop-dev@lucene.apache.org
Subject: [jira] Updated: (HADOOP-2261) [hbase] Change abort to finalize;
 does nothing if commit ran successfully
In-Reply-To: <6581179.1195710703386.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman updated HADOOP-2261:
----------------------------------

    Status: Patch Available  (was: Reopened)

> [hbase] Change abort to finalize; does nothing if commit ran successfully
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-2261
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2261
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: Jim Kellerman
>             Fix For: 0.16.0
>
>         Attachments: patch.txt
>
>
> From Michael Bieniosek:
> {code}I'm trying to do an update row, so I write code like:
> long lockid = table.startUpdate(new Text(article.getName())); try {
>      for (File articleInfo: article.listFiles(new NonDirectories())) {          articleTable.put(lockid, columnName(articleInfo.getName()), readFile(articleInfo));     }
>      table.commit(lockid);
> } finally {
>     table.abort(lockid);
> }
> This doesn't work, because in the normal case it calls abort after commit.  But I'm not sure what the code should be, eg.:
> long lockid = table.startUpdate(new Text(article.getName())); try {
>      for (File articleInfo: article.listFiles(new NonDirectories())) {          articleTable.put(lockid, columnName(articleInfo.getName()), readFile(articleInfo));     }
>      table.commit(lockid);
> } catch (IOException e) {
>     table.abort(lockid);
>     throw e;
> } catch (RuntimeException e) {
>     table.abort(lockid);
>     throw e;
> }
> This gets unwieldy very quickly.  Could you maybe change abort() to finalize() which either aborts or does nothing if a commit was successful?
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.