hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian Woodhead (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-2202) JobControl.java generates compiler warnings with Java6
Date Thu, 22 Nov 2007 13:49:43 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Adrian Woodhead updated HADOOP-2202:
------------------------------------

        Fix Version/s: 0.16.0
             Assignee: Doug Cutting
    Affects Version/s: 0.15.0
               Status: Patch Available  (was: Open)

Fix should be self-explanatory when you look at the code.

As an aside, I always prefer to use the interface (e.g. List) rather than the concrete implementation
(e.g. ArrayList) wherever possible, especially in methods which are in a public API (this
is also recommended by Sun and many others). I notice the Job class exposes the depending
jobs as an ArrayList, I think this should be changed to List. If you agree maybe a separate
Jira issue is in order? I'm quite happy to code up a patch for it.

> JobControl.java generates compiler warnings with Java6
> ------------------------------------------------------
>
>                 Key: HADOOP-2202
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2202
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.15.0
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2202-1.patch
>
>
> The following compiler warning is seen with Java6:
> {noformat}
>     [javac] /home/cutting/src/hadoop/trunk/src/java/org/apache/hadoop/mapred/jobcontrol/Job.java:221:
warning: [unchecked] unchecked call to add(E) as a member of the raw type java.util.ArrayList
>     [javac]       return this.dependingJobs.add(dependingJob);
>     [javac]                                    ^
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message