hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian Woodhead (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2268) Job.java should expose jobs as Lists rather than ArrayLists
Date Fri, 23 Nov 2007 14:58:43 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545043
] 

Adrian Woodhead commented on HADOOP-2268:
-----------------------------------------

This actually isn't such a big issue, in the original description for HADOOP-2202, cutting
reported the compiler problem being in JobControl.java, but it is actually in Job.java. I
will post a patch in a minute which fixes the compiler warning reported in HADOOP-2202 and
also changes the type of the exposed dependingJobs list to List rather than ArrayList.

The problem of List vs. ArrayList is also present in JobControl.java but if that is to be
resolved I guess it should be a new issue.

> Job.java should expose jobs as Lists rather than ArrayLists
> -----------------------------------------------------------
>
>                 Key: HADOOP-2268
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2268
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.15.0
>            Reporter: Adrian Woodhead
>            Assignee: Adrian Woodhead
>            Priority: Minor
>             Fix For: 0.16.0
>
>
> See HADOOP-2202 for background on this issue. Arun C. Murthy agrees that when possible
it is preferable to program against the interface rather than a concrete implementation (more
flexible, allows for changes of the implementation in future etc.) JobControl currently exposes
running, waiting, ready, successful and dependent jobs as ArrayList rather than List. I propose
to change this to List.
> I will code up a patch for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message