hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian Woodhead (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2202) JobControl.java generates compiler warnings with Java6
Date Thu, 22 Nov 2007 16:19:43 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544845
] 

Adrian Woodhead commented on HADOOP-2202:
-----------------------------------------

The reason findbugs is breaking on my patch is as follows (output from ant):

findbugs:
    [mkdir] Created dir: /tmp/trunk/build/test/findbugs
 [findbugs] Running FindBugs...
 [findbugs] Exception in thread "main" java.util.zip.ZipException: Error opening /tmp/trunk/build/hadoop-0.16.0-dev-streaming.jar
 [findbugs]     at edu.umd.cs.findbugs.classfile.impl.ZipFileCodeBase.<init>(ZipFileCodeBase.java:61)
 [findbugs]     at edu.umd.cs.findbugs.classfile.impl.ClassFactory.createFilesystemCodeBase(ClassFactory.java:96)
 [findbugs]     at edu.umd.cs.findbugs.classfile.impl.FilesystemCodeBaseLocator.openCodeBase(FilesystemCodeBaseLocator.java:63)
 [findbugs]     at edu.umd.cs.findbugs.classfile.impl.ClassPathBuilder.processWorkList(ClassPathBuilder.java:381)
 [findbugs]     at edu.umd.cs.findbugs.classfile.impl.ClassPathBuilder.build(ClassPathBuilder.java:192)
 [findbugs]     at edu.umd.cs.findbugs.FindBugs2.buildClassPath(FindBugs2.java:432)
 [findbugs]     at edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:160)
 [findbugs]     at edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:1521)
 [findbugs]     at edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:731)
 [findbugs] Output saved to /tmp/trunk/build/test/findbugs/hadoop-findbugs-report.xml
     [xslt] Processing /tmp/trunk/build/test/findbugs/hadoop-findbugs-report.xml to /tmp/trunk/build/test/findbugs/hadoop-findbugs-report.html
     [xslt] Loading stylesheet /opt/java/findbugs/src/xsl/default.xsl
     [xslt] : Error! Premature end of file.
     [xslt] : Error! com.sun.org.apache.xml.internal.utils.WrappedRuntimeException: Premature
end of file.
     [xslt] Failed to process /tmp/trunk/build/test/findbugs/hadoop-findbugs-report.xml

BUILD FAILED
/tmp/trunk/build.xml:599: javax.xml.transform.TransformerException: javax.xml.transform.TransformerException:
com.sun.org.apache.xml.internal.utils.WrappedRuntimeException: Premature end of file.

----------------

The "tar" target which the "findbugs" target depends on is not generating the file hadoop-0.16.0-dev-streaming.jar.
Line 594 of build.xml specifically mentions hands this file over to findbugs and if it isn't
there you get the above. If I comment out that line the build goes fine, as does findbugs
and my patch doesn't seem to introduce any new findbugs errors in JobControl.java. 

Should I create a new issue for the missing streaming.jar and it's impact on findbugs? Will
that have to be solved before this patch can be accepted?


> JobControl.java generates compiler warnings with Java6
> ------------------------------------------------------
>
>                 Key: HADOOP-2202
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2202
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.15.0
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2202-1.patch
>
>
> The following compiler warning is seen with Java6:
> {noformat}
>     [javac] /home/cutting/src/hadoop/trunk/src/java/org/apache/hadoop/mapred/jobcontrol/Job.java:221:
warning: [unchecked] unchecked call to add(E) as a member of the raw type java.util.ArrayList
>     [javac]       return this.dependingJobs.add(dependingJob);
>     [javac]                                    ^
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message