hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-2207) Add 'package' target to contrib/build-contrib.xml
Date Thu, 15 Nov 2007 21:27:43 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542890
] 

Hadoop QA commented on HADOOP-2207:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12369560/2207.patch
against trunk revision r595406.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1102/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1102/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1102/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1102/console

This message is automatically generated.

> Add 'package' target to contrib/build-contrib.xml
> -------------------------------------------------
>
>                 Key: HADOOP-2207
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2207
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: 2207.patch
>
>
> Currently, contribs each build a jar file that is deployed to the contrib directory when
hadoop is packaged.  Here is a listing:
> {code}
> ls build/hadoop-0.16.0-dev/contrib/
> hadoop-0.16.0-dev-abacus-examples.jar
> hadoop-0.16.0-dev-abacus.jar
> hadoop-0.16.0-dev-datajoin-examples.jar hadoop-0.16.0-dev-datajoin.jar
> hadoop-0.16.0-dev-hbase.jar
> hadoop-0.16.0-dev-streaming.jar
> {code}
> This works when the contrib product is a jar only.
> The hbase contrib needs to add scripts, configurations and its own jar dependencies.
 HADOOP-1648 proposed amending the general cluster CLASSPATH to add contrib jars (contrib
dependencies would be added to lib/contrib).  HADOOP-2196 was proposing that hbase scripts
be installed into the bin directory beside the hadoop core scripts.
> Discussion up on #hadoop IRC channel this morning came up w/ a solution that better keeps
the separation between whats core and whats contrib.  In synopsis, responsibility for the
contrib packaging is passed down to contribs as a new target in build-contrib.xml.  The default
would build the jar as is done now only rather than package the jar under the contrib directory,
instead, the contrib jar would be put into a subdirectory named for the contrib.  So for hbase,
instead of packaging the hbase jar at contrib/hadoop-X.X.X-hbase.jar, instead it would sit
at contrib/hbase/hadoop-X.X.X-hbase.jar .  Those contribs that comprise of more than just
a jar product -- e.g. hbase with its start/stop scripts, dependent libraries and configurations
-- on invocation of the 'package' target, would create a bin, lib, and conf directory inside
contrib/hbase/.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message