Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 932 invoked from network); 4 Oct 2007 21:50:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Oct 2007 21:50:49 -0000 Received: (qmail 47675 invoked by uid 500); 4 Oct 2007 21:50:37 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 47644 invoked by uid 500); 4 Oct 2007 21:50:37 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 47635 invoked by uid 99); 4 Oct 2007 21:50:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Oct 2007 14:50:37 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Oct 2007 21:50:40 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 99CEB714035 for ; Thu, 4 Oct 2007 14:49:50 -0700 (PDT) Message-ID: <9808014.1191534590619.JavaMail.jira@brutus> Date: Thu, 4 Oct 2007 14:49:50 -0700 (PDT) From: "Konstantin Shvachko (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Updated: (HADOOP-1997) TestCheckpoint fails on Windows In-Reply-To: <20648038.1191533931008.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Shvachko updated HADOOP-1997: ---------------------------------------- Fix Version/s: 0.15.0 Status: Patch Available (was: Open) > TestCheckpoint fails on Windows > ------------------------------- > > Key: HADOOP-1997 > URL: https://issues.apache.org/jira/browse/HADOOP-1997 > Project: Hadoop > Issue Type: Bug > Components: dfs > Affects Versions: 0.15.0 > Environment: Windows > Reporter: Konstantin Shvachko > Assignee: Konstantin Shvachko > Priority: Blocker > Fix For: 0.15.0 > > Attachments: TestCheckpoint.patch > > > The bug is in the test. TestCheckpoint opens edits files in order to verify its length but does not close it, so the > secondary name-node attempt to delete it (in order to move edits.new into it on Win) fails. > But this revealed 3 more bugs. > - FSEditLog.purgeEditLog() in case of delete / rename failure calls FSEditLog.processIOError(), which should have > failed because all FSEditLog streams are closed by that time. It does not because the condition for throwing the > exception is incorrect. > - In fact purgeEditLog() should call directly FSImage.processIOError() because again all streams are closed. > - FSImage.processIOError() should also throw an exception if number of directories is <=1 rather than when it == 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.