hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghu Angadi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1826) Side classes should be moved to separate files
Date Tue, 04 Sep 2007 20:54:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524874
] 

Raghu Angadi commented on HADOOP-1826:
--------------------------------------


I will submit a patch for BlockCrcUpgrade.java, that moves outer classes to static inners.


> Side classes should be moved to separate files
> ----------------------------------------------
>
>                 Key: HADOOP-1826
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1826
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.15.0
>
>
> The following classes are "side" classes that aren't in files with the same name. This
caused problems last night because ant compiled things in the wrong order and couldn't find
one of the relevant classes. I think it would make the code easier to read and understand
if you could always find a given class in the expected place.
> {code}
> > find src/java -name '*.java' | xargs grep '^class' | sed -e 's|\([a-zA-Z0-9/]*/\)\([^/.]*\)[.]java:class
\([^ <]*\).*|\1 \2 \3|' | awk '{if ($2 != $3) print $1$2".java",$3}'
> src/java/org/apache/hadoop/mapred/BasicTypeSorterBase.java MRSortResultIterator
> src/java/org/apache/hadoop/dfs/BlockCommand.java DatanodeCommand
> src/java/org/apache/hadoop/dfs/Storage.java StorageInfo
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcInfo
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java DNBlockUpgradeInfo
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcUpgradeUtils
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcUpgradeObjectDatanode
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcUpgradeObjectNamenode
> src/java/org/apache/hadoop/dfs/INode.java INodeDirectory
> src/java/org/apache/hadoop/dfs/INode.java INodeFile
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message