Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 47004 invoked from network); 21 Aug 2007 21:10:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 Aug 2007 21:10:54 -0000 Received: (qmail 37925 invoked by uid 500); 21 Aug 2007 21:10:51 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 37649 invoked by uid 500); 21 Aug 2007 21:10:50 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 37640 invoked by uid 99); 21 Aug 2007 21:10:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Aug 2007 14:10:50 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Aug 2007 21:11:27 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A78FB714208 for ; Tue, 21 Aug 2007 14:10:30 -0700 (PDT) Message-ID: <31005405.1187730630684.JavaMail.jira@brutus> Date: Tue, 21 Aug 2007 14:10:30 -0700 (PDT) From: "Doug Cutting (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Commented: (HADOOP-1601) GenericWritable should use ReflectionUtils.newInstance to avoid problems with classloaders In-Reply-To: <13185558.1184259845845.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521592 ] Doug Cutting commented on HADOOP-1601: -------------------------------------- You've also patched UpgradeUtilities to sort directories. This makes good sense, but is it really related to this issue, or should it rather be a separate issue? > GenericWritable should use ReflectionUtils.newInstance to avoid problems with classloaders > ------------------------------------------------------------------------------------------ > > Key: HADOOP-1601 > URL: https://issues.apache.org/jira/browse/HADOOP-1601 > Project: Hadoop > Issue Type: Bug > Components: io > Affects Versions: 0.15.0 > Reporter: Owen O'Malley > Assignee: Enis Soztutar > Fix For: 0.15.0 > > Attachments: genericWritable_v1.0.patch, genericWritable_v1.1.patch, genericWritable_v1.2-sortFiles.patch > > > GenericWritable currently uses Class.newInstance and it should use hadoop.utils.ReflectionUtils.newInstance. Furthermore, GenericWritable should be Configurable and should configure the nested objects. This will prevent a lot of classloader issues and allow the objects to get a configuration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.