Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 9291 invoked from network); 17 Aug 2007 21:54:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Aug 2007 21:54:55 -0000 Received: (qmail 24910 invoked by uid 500); 17 Aug 2007 21:54:51 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 24879 invoked by uid 500); 17 Aug 2007 21:54:51 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 24870 invoked by uid 99); 17 Aug 2007 21:54:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Aug 2007 14:54:51 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Aug 2007 21:55:16 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id F200C71418F for ; Fri, 17 Aug 2007 14:54:30 -0700 (PDT) Message-ID: <27990952.1187387670968.JavaMail.jira@brutus> Date: Fri, 17 Aug 2007 14:54:30 -0700 (PDT) From: "Doug Cutting (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Commented: (HADOOP-1436) Redesign Tool and ToolBase API and releted functionality In-Reply-To: <10697301.1180122676437.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520685 ] Doug Cutting commented on HADOOP-1436: -------------------------------------- This looks reasonable to me. Does anyone have any objections, or should I commit this? > Redesign Tool and ToolBase API and releted functionality > -------------------------------------------------------- > > Key: HADOOP-1436 > URL: https://issues.apache.org/jira/browse/HADOOP-1436 > Project: Hadoop > Issue Type: Improvement > Components: util > Affects Versions: 0.15.0 > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Fix For: 0.15.0 > > Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch, redesignToolAPI_v1.3.patch > > > With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities. > 1. Classes do not need to extend ToolBase > 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public > 3. We need a ToolRunner, or similar functionality > 4. Also we need each class (implementing Tool) to be runnable (main method) > 5. CLI objects can be passed to run method of the Tool class (arguable) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.