hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nigel Daley <nda...@yahoo-inc.com>
Subject Re: [jira] Commented: (HADOOP-1231) Add generics to Mapper and Reducer interfaces
Date Mon, 06 Aug 2007 04:27:48 GMT
Hi Tom,

The Hadoop nightly build uses the src/test/checkstyle.xml as  
expected, but the patch process copies in a custom version of both  
the xml and xsl.  The custom version only has the following rules  
enabled since that is all we've cleaned up in the code base.

         <module name="Indentation">
             <property name="basicOffset" value="2" />
             <property name="caseIndent" value="2" />

Even with just these 2 rules enabled there are lots of warnings so I  
haven't yet gone the extra step to fail a patch build if these rules  
are violated.  Since the checkstyle stuff is only half implemented in  
the patch process, I'll just remove it and resubmit your patch.

On Aug 5, 2007, at 1:33 PM, Tom White (JIRA) wrote:

>     [ https://issues.apache.org/jira/browse/HADOOP-1231? 
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment- 
> tabpanel#action_12517788 ]
> Tom White commented on HADOOP-1231:
> -----------------------------------
> Hmm. Hudson says that patching src/test/checkstyle.xml failed, but  
> it is OK when I try it on my machine. (I've made a change that says  
> documentation for a class' type parameters is not always required -  
> which is consistent with the JDK for example. See http:// 
> checkstyle.sourceforge.net/config_javadoc.html#JavadocType)
> Nigel - any ideas?
>> Add generics to Mapper and Reducer interfaces
>> ---------------------------------------------
>>                 Key: HADOOP-1231
>>                 URL: https://issues.apache.org/jira/browse/ 
>> HADOOP-1231
>>             Project: Hadoop
>>          Issue Type: Improvement
>>          Components: mapred
>>            Reporter: Owen O'Malley
>>            Assignee: Tom White
>>             Fix For: 0.15.0
>>         Attachments: HADOOP-1231.patch, HADOOP-1231.patch,  
>> MapReduceTypes.html
>> By making the input and output types of the Mapper and Reducers  
>> generic, we can get the information from the classes and not  
>> require the user to set them in the configuration.
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.

View raw message