hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-1737) [hbase] Make HColumnDescriptor data publically members settable
Date Mon, 20 Aug 2007 19:47:30 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HADOOP-1737:
--------------------------

    Attachment: hadoop-1737.patch

Here's a first attempt.

HADOOP-1737 Make HColumnDescriptor data publically members settable

M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStore.java
    Use new HColumnDescriptor accessors rather than make direct accesses
M  src/contrib/hbase/src/java/org/apache/hadoop/hbase/HColumnDescriptor.java
    (COMPRESSION_NONE, COMPRESSION_RECORD, COMPRESSION_BLOCK): Removed.
    Use enum ordinals instead.  Removed mapping between these defines and
    enum equivalents.  Made data members private and added accessors.
    (DEFAULT_IN_MEMORY, DEFAULT_COMPRESSION_TYPE,
      DEFAULT_BLOOM_FILTER_DESCRIPTOR, DEFAULT_MAX_VALUE_LENGTH): Added.

> [hbase] Make HColumnDescriptor data publically members settable 
> ----------------------------------------------------------------
>
>                 Key: HADOOP-1737
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1737
>             Project: Hadoop
>          Issue Type: Bug
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>         Attachments: hadoop-1737.patch
>
>
> On the list Inchol Song made the following reasonable request:
> Inchul Song wrote:
> > I am making changes to Hbase Shell to add support for
> > the new CREATE TABLE syntax. (See issue HADOOP-1720.)
> >
> > But there are only two useful constructors in class HColumnDescriptor
> > for column creation, one with an argument specifying a column name,
> > the other with a number of arguments specifying all the options
> > for the column such as a compression method, max length, and so on,
> >
> > In a CREATE TABLE statement, when a user specifies only
> > some of the available options, I'd like to fill in the remaining options
> > with their default values. I expected to access those default values as
> > public static fields of the HColumnDescriptor class, but those values
> > were hidden in the class as private fields. So I had to look into
> > the source code of the HColumnDescriptor class to find out
> > which default values are used in its single argument constructor.
> >
> > I think it would be useful to make the default option values
> > in the HColumnDescriptor class as public static fields.
> >
> > Is there any reason not to make them public static fields?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message