hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrzej Bialecki (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1727) Make ...hbase.io.MapWritable more generic so that it can be included in ...hadoop.io
Date Tue, 21 Aug 2007 16:36:31 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521519
] 

Andrzej Bialecki  commented on HADOOP-1727:
-------------------------------------------

The patch looks good to me, with the exception of one important issue: AbstractMapWritable
should implement Configurable. When instances of Configurable are deserialized, ReflectionUtils
will make sure that current Configuration will be set - this ensures in our case that all
contained keys and values that need to be deserialized (and which themselves implement Configurable)
can be properly reconstructed using non-null Configuration.

> Make ...hbase.io.MapWritable more generic so that it can be included in ...hadoop.io
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1727
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1727
>             Project: Hadoop
>          Issue Type: New Feature
>          Components: io
>    Affects Versions: 0.15.0
>            Reporter: Jim Kellerman
>            Assignee: Jim Kellerman
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: patch.txt, patch.txt, patch.txt, patch.txt
>
>
> The class org.apache.hadoop.hbase.io.MapWritable could be made more generic through the
use of ReflectionUtils so that it could support more Map key and value classes. Currently
it supports Map<WritableComparable, Writable> only.
> When more generalized, submit for consideration to be included in org.apache.hadoop.io

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message