hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "dhruba borthakur (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1541) ipc.Server INFO message shouldn't include an Exception trace
Date Mon, 16 Jul 2007 19:30:06 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513003
] 

dhruba borthakur commented on HADOOP-1541:
------------------------------------------

I agree that we should not rely on exceptions to handle a normal control flow. But this patch
has nothing to do with "deletion of a non-existent file". The FileSystem.isDir() method invokes
getFileInfo(). if the file does not exist, then getFileInfo() throws an exception. The Filesystem.isDir()
method catches this exception and returns false.

The "masking the exception" is being done on the client by FileSystem.isDir().

> ipc.Server INFO message shouldn't include an Exception trace
> ------------------------------------------------------------
>
>                 Key: HADOOP-1541
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1541
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.14.0
>            Reporter: Nigel Daley
>            Assignee: dhruba borthakur
>            Priority: Blocker
>             Fix For: 0.14.0
>
>         Attachments: ipcExceptionLog2.patch
>
>
> I see a lot of these in the NN log.  I don't think an INFO message should contain an
error message and stack trace.
> 2007-06-28 00:21:51,057 INFO org.apache.hadoop.ipc.Server: IPC Server handler 7 on 8020,
call getFileInfo(/user/hadoopqa/mapred.loadtest/intermediateouts) from 2.2.2.2:47476: error:
java.io.IOException: File does not exist
> java.io.IOException: File does not exist
>         at org.apache.hadoop.dfs.FSDirectory.getFileInfo(FSDirectory.java:716)
>         at org.apache.hadoop.dfs.FSNamesystem.getFileInfo(FSNamesystem.java:1178)
>         at org.apache.hadoop.dfs.NameNode.getFileInfo(NameNode.java:479)
>         at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:340)
>         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:566)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message