hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug Cutting <cutt...@apache.org>
Subject Re: [jira] Commented: (HADOOP-1489) Input file get truncated for text files with \r\n
Date Wed, 20 Jun 2007 18:46:00 GMT
Michael Stack wrote:
> If your patch fails, set the issue status to 'Resume Progress', upload a 
> patch with fix and then set the status to 'Submit Patch' again.

Keep in mind, however, that the primary purpose of submitting patches is 
to get a committer to review and commit them, not to run Hudson tests. 
Folks should run 'ant clean test javadoc checkstyle' before submitting 
patches.  Tests should pass.  Javadoc should report no errors. 
Checkstyle's error count should not exceed that listed at:

http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/lastSuccessfulBuild/artifact/trunk/build/test/checkstyle-errors.html

Hudson's tests should only double-check things, and not be used as a 
primary tester, which would create too much noise on this list and in 
Jira.  Submitting patches that fail Hudson testing is frowned on, 
(unless the failure is not actually due to the patch).

Doug

Mime
View raw message