hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1517) Three methods in FSNamesystem should not be synchronized.
Date Thu, 21 Jun 2007 21:46:26 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507042
] 

Hadoop QA commented on HADOOP-1517:
-----------------------------------

+1

http://issues.apache.org/jira/secure/attachment/12360314/NameSystemSync.patch applied and
successfully tested against trunk revision r549605.

Test results:   http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/320/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/320/console

> Three methods in FSNamesystem should not be synchronized.
> ---------------------------------------------------------
>
>                 Key: HADOOP-1517
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1517
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>            Priority: Critical
>             Fix For: 0.14.0
>
>         Attachments: NameSystemSync.patch
>
>
> Joining my UTF8 patch HADOOP-1283 with synchronization changes introduced by HADOOP-1269
> I missed to remove synchronization modifiers in the following three methods:
> startFile()
> getAdditionalBlock()
> allocateBlock()
> Fine grained locking does not work if the first two methods are synchronized.
> This is the patch that removes them. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message