hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1375) a simple parser for hbase.
Date Wed, 27 Jun 2007 19:14:26 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508625

stack commented on HADOOP-1375:

Hey Jinsuk:  Wait up on moving this issue to the 'submit patch' phase until you get a +1 from
a reviewer (If you haven't read 'Contributing your work' from this http://wiki.apache.org/lucene-hadoop/HowToContribute,
you should check it out).

Here are comments on latest patch:

+ When I do 'show help;', it starts out 'SHOW       - Show command will list the tables.'.
 So, I type 'show;' and it complains:
HBase > show;
Missing Parameters! Please check 'show' syntax.

Fix the help or fix the 'show' command (When I do 'help show;', the help is still wrong).

+ The 'DESC' help output in same screen wraps 'columnfamilies' as do a bunch of the other
descriptions on the help page.
+ I would suggest that for v1 of hbaseshell, you not complicate things by including support
for SUBSTITUTE, PRINT, and STORE especially as they do not seem to work and a few commands
report unimplemented. Stick w/ shell basics so we can make a commit.
+ The below is still a problem:
HBase > create table;
Exception in thread "main" java.lang.NullPointerException
        at org.apache.hadoop.hbase.shell.commands.Create.checkParams(Create.java:34)
        at org.apache.hadoop.hbase.shell.commands.Create.execute(Create.java:44)
        at org.apache.hadoop.hbase.shell.HBaseShell.main(HBaseShell.java:68)
as is this:
HBase > select --ROOT--;
Exception in thread "main" java.lang.Error: Missing return statement in function
        at org.apache.hadoop.hbase.shell.generated.Parser.parse(Parser.java:200)
        at org.apache.hadoop.hbase.shell.HBaseShell.main(HBaseShell.java:65)
+ This doesn't work.
HBase > create x columnfamilies('x', 'y') limit=2;
Missing Parameters! Please check 'create' syntax.
Doesn't work even if double-quotes or if families end in colons.  Same 'missing parameters'

Thats enough for now.  Your patch is getting better on each submission.  I like the addition
of the unit tests, the formatting fixes, etc.  I'd suggest focusing on getting a basic functionality
working so we can make a commit.

> a simple parser for hbase.
> --------------------------
>                 Key: HADOOP-1375
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1375
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.13.0
>         Environment: All environments 
>            Reporter: udanax
>            Priority: Minor
>             Fix For: 0.14.0
>         Attachments: hadoop1375-v12.patch, hbase_shell_base.patch, jline-0.9.91.jar,
patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt,
patch.txt, patch.txt
> http://wiki.apache.org/lucene-hadoop/HbaseShell (work in progress)
> HBase Shell is developed to achieve the following goals. 
>  * Generic Monitoring Function 
>  * A Simplified Import/Export/Migrate Functionality Between different data sources (Hadoop,
>  * A Simplified processing of a logical data model 
>  * A Simplified algebraic operations 
>    (Parallel Numerical Analysis by abstracting/numericalizing points, lines, or plane
data across multiple maps in HBase.)
> {code}
> [# root@localhost] ./bin/hadoop jar ./build/hadoop-hbase org.apache.hadoop.hbase.shell.HbaseShell
> Hbase > help;
> blah blah...
> Hbase > create webtable 
>      --> columnfamilies('anchors', 'language') limit=3;
> Hbase > set webtable values('anchors:http://www.udanax.org/','opensource') where row="http://www.hadoop.co.kr";
> Hbase > scan webtable where row="http://www.hadoop.co.kr";
> blah blah...
> Hbase > set webtable values('language:kr','euc-kr') where row="http://www.hadoop.co.kr";
> Hbase > scan webtable where row="http://www.hadoop.co.kr" and column="language:kr";
> blah blah...
> Hbase > scan webtable;
> Hbase > exit
> [# root@localhost] 
> {code}

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message