hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "dhruba borthakur (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1508) ant Task for FsShell operations
Date Wed, 20 Jun 2007 06:49:26 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506411
] 

dhruba borthakur commented on HADOOP-1508:
------------------------------------------

3. The methods test() and touch() in FsShell.java should be package private instead of public.
4. The explanation for touch says that "if the file already exists, then it is overwritten".
 But files in DFSland cannot be overwritten. The code seems to thrown an exception if the
file already exists.
5. The semantics to touch might need some explanation. For example, the FsShell first sees
if the file exists using fs.exists(). If it does not then it tries to create the file. But
there is no locking between the exists() and create(). Is this sufficient?
6. The method FsShell.test() is supposed to return an int. However, it is not returning any
value. This should have resulted in a compilation warning, unless I am missing something.
7. Why is the 'test' command secret and not documented?

> ant Task for FsShell operations
> -------------------------------
>
>                 Key: HADOOP-1508
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1508
>             Project: Hadoop
>          Issue Type: New Feature
>          Components: build, fs
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: HADOOP-1508.patch
>
>
> This issue will document the requirements, design and implementation of an ant Task providing
FsShell functionality within that framework.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message