Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 53633 invoked from network); 29 May 2007 18:36:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 29 May 2007 18:36:39 -0000 Received: (qmail 23414 invoked by uid 500); 29 May 2007 18:36:41 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 23389 invoked by uid 500); 29 May 2007 18:36:41 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 23379 invoked by uid 99); 29 May 2007 18:36:41 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 May 2007 11:36:41 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 May 2007 11:36:36 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 4A9CC71417F for ; Tue, 29 May 2007 11:36:16 -0700 (PDT) Message-ID: <11348568.1180463776301.JavaMail.jira@brutus> Date: Tue, 29 May 2007 11:36:16 -0700 (PDT) From: "Hairong Kuang (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Commented: (HADOOP-1392) FindBugs : Fix some correctness bugs reported in DFS, FS, etc. In-Reply-To: <11036725.1179524776121.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499881 ] Hairong Kuang commented on HADOOP-1392: --------------------------------------- One minor suggestion. For the following fix for NamenodeFsck.java, chosenNode = nodes[r.nextInt(Integer.MAX_VALUE) % nodes.length] I would prefer chosenNode = nodes[r.nextInt(nodes.length)] > FindBugs : Fix some correctness bugs reported in DFS, FS, etc. > -------------------------------------------------------------- > > Key: HADOOP-1392 > URL: https://issues.apache.org/jira/browse/HADOOP-1392 > Project: Hadoop > Issue Type: Bug > Affects Versions: 0.12.3 > Reporter: Raghu Angadi > Assignee: Raghu Angadi > Fix For: 0.14.0 > > Attachments: HADOOP-1392-01.patch > > > Fix some correctness bugs reported by FindBugs in DFS, FS, IO, NET, etc packages. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.