hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1375) a simple parser for hbase.
Date Fri, 18 May 2007 01:43:16 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496752

stack commented on HADOOP-1375:

A couple of comments, Udanax:

+ Your patch looks like it provides an 'interpreter' (or 'shell)' for a small set of hbase
sql-like 'commands (only you use 'scan' for 'select' and 'set' for 'update', etc.).  Calling
your feature a 'parser' confuses folks.
+ In such 'shell's, usually you can type a '?' or 'help' and you will get a usage that explains
all the commands and options available.  This is missing from your patch.
+ I'd suggest that BuildTable and Row* classes belong in same package as your javacc generated
classes.  Also, you have in each of these classes a method named 'test' that should be renamed
as 'execute' or 'run'.
+ You could do 'new String(byteArray)' rather than call 'byteToString'
+ The below looks wrong (at a minimum its misspelled): 
  +	public void RowFileterIterator(){
  +	}

> a simple parser for hbase.
> --------------------------
>                 Key: HADOOP-1375
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1375
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>         Environment: All environments 
>            Reporter: udanax
>         Assigned To: Jim Kellerman
>            Priority: Minor
>         Attachments: patch.txt, patch.txt
> this is a simple parser for hbase test.
> i just write it.
> you can use this syntax to create and set.
> {code}
> [# root@localhost] ./bin/hadoop jar ./build/hadoop-hbase org.apache.hadoop.hbase.parser.HbaseParser
> Hbase > build webtable columnfamily('anchors', 'language') limit=3;
> Hbase > set webtable values('anchors:http://www.udanax.org/','opensource') where row="http://www.hadoop.co.kr";
> Hbase > scan webtable where row="http://www.hadoop.co.kr";
> blah blah...
> Hbase > set webtable values('language:kr','euc-kr') where row="http://www.hadoop.co.kr";
> Hbase > scan webtable where row="http://www.hadoop.co.kr" and column="kr" and columnfamily="language";
> Hbase > exit
> [# root@localhost] 
> {code}

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message