Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hadoop-dev@lucene.apache.org
Message-ID: <19933195.1177455315407.JavaMail.jira@brutus>
Date: Tue, 24 Apr 2007 15:55:15 -0700 (PDT)
From: "dhruba borthakur (JIRA)" <jira@apache.org>
To: hadoop-dev@lucene.apache.org
Subject: [jira] Updated: (HADOOP-1272) Extract InnerClasses from
 FSNamesystem into separate classes
In-Reply-To: <4599173.1177016715284.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated HADOOP-1272:
-------------------------------------

    Attachment: innerclasses3.patch

This incorporates most of Konstantin's comments. 

1. I kept the wrapper method updateNeededReplications  but removed removeNeededReplications and addNeededReplications. 

2. Removed all import warnings. 

3. I kept a seperate class for SafeModeInfo because I think this is the right way to go in the long run. It will help us in getting fine-grain locking easy to understand.

4. Separated out the servlet classes into its own file(s).

> Extract InnerClasses from FSNamesystem into separate classes
> ------------------------------------------------------------
>
>                 Key: HADOOP-1272
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1272
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: dhruba borthakur
>         Assigned To: dhruba borthakur
>         Attachments: innerclasses3.patch
>
>
> This will make the code cleaner. Also, it leads itself to a cleaner and easily understandable finer-grain locking model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.