hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1272) Extract InnerClasses from FSNamesystem into separate classes
Date Fri, 20 Apr 2007 22:42:15 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490467
] 

Konstantin Shvachko commented on HADOOP-1272:
---------------------------------------------

I would start extracting servlet classes first. In general Servlets should be in a different
package or sub-package, e.g.
org.apache.hadoop.dfs.servlets
Then there are some straightforward static inner classes, like Host2NodesMap.
Then BlocksMap and FileUnderConstruction, which are practically static although not declared
as such.
It is easy to extract ReplicationTargetChooser, just move clusterMap inside the chooser and
provide api for modification and the access.

In general we should not multiply inner classes but rather create separate ones.
Should we add that into code review guidelines?


> Extract InnerClasses from FSNamesystem into separate classes
> ------------------------------------------------------------
>
>                 Key: HADOOP-1272
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1272
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: dhruba borthakur
>         Assigned To: dhruba borthakur
>         Attachments: innerclasses.patch
>
>
> This will make the code cleaner. Also, it leads itself to a cleaner and easily understandable
finer-grain locking model.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message