hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1148) re-indent all code
Date Tue, 17 Apr 2007 16:41:15 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489456
] 

Doug Cutting commented on HADOOP-1148:
--------------------------------------

> I think default behavior of 2 space indentation in one editor won't be same as 2 space
indentation in another editor.

Right.  The biggest variation seems to be around parameter indentation, whether a call is
indented as: {{
foo(a,
      b,
      c);
}} as by emacs, or as {{
foo(a,
  b,
  c);
}}
as by eclipse.

Owen says he knows a way to get eclipse to use the former.  I prefer the former, but would
certainly not bounce a patch for using the latter.  I'm not sure which the style checker prefers,
if any.



> re-indent all code
> ------------------
>
>                 Key: HADOOP-1148
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1148
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>         Assigned To: Doug Cutting
>            Priority: Minor
>             Fix For: 0.13.0
>
>
> We should re-indent all code to consistently use 2-spaces per level.  This will not invalidate
outstanding patches: one can use the '-l' option to ignore whitespace differences in patches.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message