hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "dhruba borthakur (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-1184) Decommission fails if a block that needs replication has only one replica
Date Mon, 30 Apr 2007 18:27:15 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

dhruba borthakur updated HADOOP-1184:
-------------------------------------

    Attachment: decommissionOneReplica5.patch

Thanks Hairong for the review comments.  

1. Fixed indentation in a few places.
2. Yes, I agree with you that we need to check the pendingReplication queue too. I added this
change. This was a good catch! Thanks.
3. I changed the variable name from nonCommisiionedNodeList to nodeList. I did not create
a static class (yet) for the return values. If you feel strongly about it, then I can do it.
Please let me know.
4. I agree that the test should pick the a node that has some blocks to be decommissioned.
Without changing MiniCluster, one way to go about it is to make getFileHints() return the
hostname and the port of the datanode on which the block resides. The test can decommission
only that node on which a block resides. Currently, getFileHints() returns only the hostname
of the datanode. As part of hadoop-1296, we can make the getFileHints() return the port number.
And then I can modify the test to decommission a node only if it has blocks on it. I will
add this comment to hadoop-1296.

> Decommission fails if a block that needs replication has only one replica
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-1184
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1184
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: dhruba borthakur
>         Attachments: decommissionOneReplica3.patch, decommissionOneReplica4.patch, decommissionOneReplica5.patch
>
>
> If the only replica of a block resides on a node being decommissioned, then the decommission
command does not complete. The blocks do not get added to neededReplication because neededReplications.update()
believes that the number of current replicas is zero.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message