hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1148) re-indent all code
Date Tue, 17 Apr 2007 18:33:16 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489503
] 

Doug Cutting commented on HADOOP-1148:
--------------------------------------

bq. I manually override this alignment to keep the text with in 80 columns.

A better way to fix that, if no other options are available, is to put the newline before
the parenthesis:{noformat}
aVeryVeryLongVariableName.aVeryVeryLongMethodName
  (firstVeryVeryLongParameterName,
   secondVeryVeryLongParameterName,
   thirdVeryVeryLongParameterName);
{noformat}

bq. I think in your automated conversion some of these have crossed the 80 columns.

Yes, but I don't think we should fix 80-column violations wholesale, since that would break
outstanding patches.  With indentation-only changes, existing patches can still be easily
applied.

> re-indent all code
> ------------------
>
>                 Key: HADOOP-1148
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1148
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>         Assigned To: Doug Cutting
>            Priority: Minor
>             Fix For: 0.13.0
>
>
> We should re-indent all code to consistently use 2-spaces per level.  This will not invalidate
outstanding patches: one can use the '-l' option to ignore whitespace differences in patches.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message