Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 9335 invoked from network); 2 Mar 2007 18:38:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Mar 2007 18:38:13 -0000 Received: (qmail 9125 invoked by uid 500); 2 Mar 2007 18:38:22 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 8865 invoked by uid 500); 2 Mar 2007 18:38:21 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 8852 invoked by uid 99); 2 Mar 2007 18:38:21 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 10:38:21 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 10:38:11 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 4F36C7142EF for ; Fri, 2 Mar 2007 10:37:51 -0800 (PST) Message-ID: <11241755.1172860671321.JavaMail.jira@brutus> Date: Fri, 2 Mar 2007 10:37:51 -0800 (PST) From: "Doug Cutting (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Commented: (HADOOP-1041) Counter names are ugly In-Reply-To: <5186555.1172466305502.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477402 ] Doug Cutting commented on HADOOP-1041: -------------------------------------- David, is there a reason that you've not yet marked this "Patch Available"? Should I hold off on committing it? > Counter names are ugly > ---------------------- > > Key: HADOOP-1041 > URL: https://issues.apache.org/jira/browse/HADOOP-1041 > Project: Hadoop > Issue Type: Improvement > Components: mapred > Affects Versions: 0.12.0 > Reporter: Owen O'Malley > Assigned To: David Bowen > Fix For: 0.12.0 > > Attachments: 1041.patch, 1041_1.patch > > > Having the complete class name in the counter names makes them unique, but they are ugly to present to non-developers. It would be nice to have some way to have a nicer string presented to the user. Currently, the Enum is converted to a name like: > key.getDeclaringClass().getName() + "#" + key.toString() > which gives counter names like "org.apache.hadoop.examples.RandomWriter$Counters#BYTES_WRITTEN" > which is unique, but not very user friendly. Perhaps, we should strip off the class name for presenting to the users, which would allow them to make nice names. In particular, you could define an enum type that overloaded toString to print a nice user friendly string. > Thoughts? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.