hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1148) re-indent all code
Date Fri, 23 Mar 2007 18:29:32 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483697
] 

Doug Cutting commented on HADOOP-1148:
--------------------------------------

> As much as I'd love to have two spaces everywhere I'm worried about the adverse impact
on 'svn annotate'

That is indeed the biggest cost that I can see.  To find out who last edited a line one would
have to use 'svn annotate -r XXX' where XXX is the last revision before the re-indentation.
 So there is a workaround.  Is that acceptable?

> I'd argue this is the right time to fix the line-lengths

That's more intrusive, as it would break outstanding patches.  It's also harder to do well
automatically.

> re-indent all code
> ------------------
>
>                 Key: HADOOP-1148
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1148
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>         Assigned To: Doug Cutting
>            Priority: Minor
>
> We should re-indent all code to consistently use 2-spaces per level.  This will not invalidate
outstanding patches: one can use the '-l' option to ignore whitespace differences in patches.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message