hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Bowen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1051) Add checkstyle target to ant build file
Date Thu, 01 Mar 2007 20:55:50 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477081
] 

David Bowen commented on HADOOP-1051:
-------------------------------------

+1.  I like the idea of doing this.  Following code conventions makes code easier to read
and to modify.  

It would be good to get the indentation consistent.  I don't like the 2-space convention (I
much prefer 4-space) but I'd rather have 2-space everywhere than the current situation where
the spacing is inconsistent.

Can the checkstyle jar be checked into the lib directory so that people don't have to download
it?




> Add checkstyle target to ant build file
> ---------------------------------------
>
>                 Key: HADOOP-1051
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1051
>             Project: Hadoop
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 0.11.2
>            Reporter: Tom White
>         Assigned To: Tom White
>         Attachments: checkstyle-errors.html, checkstyle.patch
>
>
> As discussed in HADOOP-948, add a target to allow people to run style checks on the codebase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message