hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug Cutting <cutt...@apache.org>
Subject Re: [jira] Commented: (HADOOP-958) Building Hadoop results in a lot of warnings
Date Thu, 29 Mar 2007 17:42:45 GMT
Nigel Daley wrote:
> Should we try to do all code format changes in a series of contiguous 
> patches?

This is more than a format change, but I see what you mean.

> This should minimize the amount of pain while diff'ing source 
> files across revisions.  Also, should these format changes be the last 
> patches applied before a release or the first patches applied after a 
> release?

I think for this issue, which is not completely automatic, my hunch is 
to pursue it piecemeal.  Also, as we more actively maintain multiple 
branches, the notions of just-before or just-after a release don't make 
quite as much sense, since these changes will affect merging.  So doing 
it all at once in one release will make all merging harder for that 
release, while spreading it over multiple releases will spread the merge 
pain out.  That said, if someone has a patch ready that updates the 
whole tree and that applies cleanly to trunk at a time when the patch 
queue is empty, then I'd vote to just commit it and deal with the 
consequences.  However the patch queue hasn't been empty for a while...


View raw message