hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrzej Bialecki ...@getopt.org>
Subject Re: Lack of progress info in map tasks
Date Fri, 16 Mar 2007 13:59:04 GMT
Espen Amble Kolstad wrote:
> It's tiny bug in SequenceFileRecordReader. A cast to float is needed here
>      return (in.getPosition() - start) / (end - start);
> gives
>      return (in.getPosition() - start) / (float) (end - start);
>
> As well as assigning start in the constructor:
>    this.start = split.getStart();

Thanks Espen, that's exactly the issue! I discovered that this bug is 
also replicated in LineRecordReader (which is used by TextInputFormat). 
I'll create a patch and submit it.

-- 
Best regards,
Andrzej Bialecki     <><
 ___. ___ ___ ___ _ _   __________________________________
[__ || __|__/|__||\/|  Information Retrieval, Semantic Web
___|||__||  \|  ||  |  Embedded Unix, System Integration
http://www.sigram.com  Contact: info at sigram dot com



Mime
View raw message