hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1051) Add checkstyle target to ant build file
Date Fri, 02 Mar 2007 17:57:51 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477389
] 

Doug Cutting commented on HADOOP-1051:
--------------------------------------

> Is it worth excluding attached files that don't have an ASF license granted too?

Or, if they're patches, adding -1 for that reason?

Also, rather than checking for other file types, couldn't we instead check that something's
indeed a patch file, and ignore all non-patch attachments?  The unix 'file' command does a
good job of identifying patches as 'RCS/CVS diff output text'.


> Add checkstyle target to ant build file
> ---------------------------------------
>
>                 Key: HADOOP-1051
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1051
>             Project: Hadoop
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 0.11.2
>            Reporter: Tom White
>         Assigned To: Tom White
>         Attachments: checkstyle-errors.html, checkstyle-v2.patch, checkstyle.patch
>
>
> As discussed in HADOOP-948, add a target to allow people to run style checks on the codebase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message