hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun C Murthy (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-1148) re-indent all code
Date Sat, 24 Mar 2007 07:46:32 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483821
] 

Arun C Murthy commented on HADOOP-1148:
---------------------------------------

> That is indeed the biggest cost that I can see. To find out who last edited a line one
would have to use 'svn annotate -r XXX' where XXX is the last revision before the re-indentation.
So there is a workaround. Is that acceptable? 

Fair enough, I guess we have to bite the bullet at some point...

I'd like to propose we put up a reasonable svn 'tag' *before* (and after?) making this change
so as to ease finding out the last revision i.e. help ease the process of finding the 'last
revision before this change'. Does that sound reasonable? (I'm assuming svn has this feature,
having used this in cvs)

> re-indent all code
> ------------------
>
>                 Key: HADOOP-1148
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1148
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>         Assigned To: Doug Cutting
>            Priority: Minor
>
> We should re-indent all code to consistently use 2-spaces per level.  This will not invalidate
outstanding patches: one can use the '-l' option to ignore whitespace differences in patches.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message