hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-1051) Add checkstyle target to ant build file
Date Fri, 02 Mar 2007 13:36:50 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tom White updated HADOOP-1051:
------------------------------

    Attachment: checkstyle-v2.patch

I too don't want to waste time arguing over which set of checks to enforce. Instead I would
suggest a lowest common denominator set of checks which are broadly uncontentious, and which
committers can run against patches at their own discretion to check that they are basically
OK.

This second patch remove's Doug's spurious warnings and adds David's change for indentation
checking.

I take the point about reasonable people differing on these issues, which is why I would not
integrate this into the build tool and instead give the committers the final say.

> Add checkstyle target to ant build file
> ---------------------------------------
>
>                 Key: HADOOP-1051
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1051
>             Project: Hadoop
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 0.11.2
>            Reporter: Tom White
>         Assigned To: Tom White
>         Attachments: checkstyle-errors.html, checkstyle-v2.patch, checkstyle.patch
>
>
> As discussed in HADOOP-948, add a target to allow people to run style checks on the codebase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message