Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hadoop-dev@lucene.apache.org
Message-ID: <21732290.1171316586587.JavaMail.jira@brutus>
Date: Mon, 12 Feb 2007 13:43:06 -0800 (PST)
From: "Doug Cutting (JIRA)" <jira@apache.org>
To: hadoop-dev@lucene.apache.org
Subject: [jira] Commented: (HADOOP-1010) getReordReader methof of
 InputFormat class should handle null reporter argument
In-Reply-To: <2196453.1171312805630.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472430 ] 

Doug Cutting commented on HADOOP-1010:
--------------------------------------

> the right way to do this is by supplying a reporter in all methods of tasks

I'm not sure exactly how  that addresses this issue.

I think we ought to add a Context parameters to most methods on core interfaces, that we can then effectively add and remove/deprecate parameters from these interfaces without breaking implementations.  For example, Owen made this a part of his proposal in HADOOP-904.  So, as we next modify each interface, I think we ought to convert to this style.  And Reporter could then be added as a getReporter() method to the context parameter used by most interfaces, removing it from the explicit parameter list, and solving this issue.  But that's a long-term fix.  The short term fix Runping attached is probably a good idea in the meantime, no?

> getReordReader methof of InputFormat class should handle null reporter argument
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-1010
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1010
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Runping Qi
>         Assigned To: Runping Qi
>         Attachments: hadoop-1010.patch
>
>
> In some cases, I need to create a record reader object in the config method of mappers. 
> At that time, reporter is not available yet. And logically, the reporter should not be a required for getRecordReader anyway.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.