hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wendy Chien (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-947) isReplicationInProgress() is very heavyweight
Date Fri, 16 Feb 2007 03:43:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473601
] 

Wendy Chien commented on HADOOP-947:
------------------------------------

The logic looks fine, but the new name, hasReachedReplicationFactor, implies the opposite
of what the comment says and what the code does.  I think keeping the old name or switching
true and false would work better.    

> isReplicationInProgress() is very heavyweight
> ---------------------------------------------
>
>                 Key: HADOOP-947
>                 URL: https://issues.apache.org/jira/browse/HADOOP-947
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: dhruba borthakur
>         Assigned To: dhruba borthakur
>         Attachments: isReplicationInProgress.patch
>
>
> Suppose a decommission is in progress. The namenode receives a heartbeat from the being-decommissioned
node and then invokes isReplicationInProgress() to determine if the decommissioned is complete.
This method is very heavyweight and chews up plenty of CPU.
> One option to fix this issue is to keep a counter to indicate how many blocks are pending
replication.  This could also help in showing a progress-status-indicator to display how far
the decommissioning process is complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message