hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Bowen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-954) Metrics should offer complete set of static report methods or none at all
Date Wed, 07 Feb 2007 23:45:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471151
] 

David Bowen commented on HADOOP-954:
------------------------------------

+1.  These changes look fine.

I think we are going to hit overflows with counting bytes.  We should change this to counting
megabytes (using a float rather than an int), but that can be another Jira ticket.



> Metrics should offer complete set of static report methods or none at all
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-954
>                 URL: https://issues.apache.org/jira/browse/HADOOP-954
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.10.1
>            Reporter: Nigel Daley
>         Assigned To: David Bowen
>            Priority: Minor
>         Attachments: HADOOP-954-2.patch, HADOOP-954-3.patch, hadoop-954.patch
>
>
> org.apache.hadoop.metrics.Metrics currently has one report method.  I should either have
report methods for all underlying MetricsRecord or no report methods at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message