hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nigel Daley <nda...@yahoo-inc.com>
Subject Re: [jira] Commented: (HADOOP-948) Coding style issues
Date Mon, 29 Jan 2007 20:11:43 GMT
> On a related note, we should really use CheckStyle (http:// 
> checkstyle.sourceforge.net) to enforce the coding styles.  
> Currently, when I run checkstyle (with sun's style conventions,  
> which we use for Hadoop) I get tons of warnings on almost each and  
> every source file.

...which is perhaps one reason it is too late to use CheckStyle.

>
>
>> Coding style issues
>> --------------------
>>
>>                 Key: HADOOP-948
>>                 URL: https://issues.apache.org/jira/browse/HADOOP-948
>>             Project: Hadoop
>>          Issue Type: Bug
>>          Components: metrics
>>            Reporter: David Bowen
>>            Priority: Minor
>>
>> I would like to recommend some mainly stylistic changes in the  
>> recent fix of http://issues.apache.org/jira/browse/HADOOP-886.   
>> The file in question is CodeFactory.java, and the reasons for the  
>> changes are:
>>    * It is generally preferable to avoid multiple return statements.
>>    * It is nearly always preferable to use curly braces and a  
>> newline after an if (condition).
>>    * There's no benefit to doing the hash lookup twice in the  
>> common case (by calling contains and then get).
>> (1) and (2) are commonly found in Java coding style guidelines as  
>> they make the code more readable.
>> I'll attach the fix shortly.
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>


Mime
View raw message