hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Milind Bhandarkar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-887) metrics API should enforce some restrictions on tag and metric names
Date Fri, 12 Jan 2007 22:29:27 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464375
] 

Milind Bhandarkar commented on HADOOP-887:
------------------------------------------

'.' is not allowed in most languages in variable and method names. Also hadoop record I/O
does not allow this character to be part of a record definition. If Metrics API is used to
collect Job stats with JobMetricsContext with IPC as a transport mechanism, one would need
the metrics record to be writable. It would be good to use Hadoop record I/O to define such
Metrics record, which means disallowing such special charracters in metric names.

> metrics API should enforce some restrictions on tag and metric names
> --------------------------------------------------------------------
>
>                 Key: HADOOP-887
>                 URL: https://issues.apache.org/jira/browse/HADOOP-887
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.10.1
>            Reporter: Nigel Daley
>            Priority: Minor
>
> The metrics API currently allows any string to be a metric name or tag name (see org.apache.hadoop.metrics.Metrics.createRecord(...)
and org.apache.hadoop.metrics .Metrics.report(...)).
> Such unrestricted names makes it difficult to implement metrics providers that generate
source code to manipulate these metrics, since many characters are invalid as method or variable
names.
> I'd like to propose that metric names be restricted to letters, digits, and underscore
(A-Za-z0-9_) and this restriction be documented and enforced by the API.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message