hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenji Matsuoka (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-905) Code to qualify inputDirs doesn't affect path validation
Date Thu, 18 Jan 2007 19:25:30 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kenji Matsuoka updated HADOOP-905:
----------------------------------

    Description: 
This code, at JobClient:306, doesn't seem to do validate the fully qualified inputDirs, since
inputDirs is a newly created arrray:

        Path[] inputDirs = job.getInputPaths();
 
        // make sure directories are fully qualified before checking them
        for(int i=0; i < inputDirs.length; ++i) {
          if (inputDirs[i].toUri().getScheme() == null) {
            inputDirs[i] = userFileSys.makeQualified(inputDirs[i]);
          }
        }

        // input paths should exist. 
        job.getInputFormat().validateInput(job);



  was:
This code, at JobClient:306, doesn't seem to do anything, since inputDirs is a newly created
arrray:

        Path[] inputDirs = job.getInputPaths();
 
        // make sure directories are fully qualified before checking them
        for(int i=0; i < inputDirs.length; ++i) {
          if (inputDirs[i].toUri().getScheme() == null) {
            inputDirs[i] = userFileSys.makeQualified(inputDirs[i]);
          }
        }

        // input paths should exist. 
        job.getInputFormat().validateInput(job);




> Code to qualify inputDirs doesn't affect path validation
> --------------------------------------------------------
>
>                 Key: HADOOP-905
>                 URL: https://issues.apache.org/jira/browse/HADOOP-905
>             Project: Hadoop
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.10.1
>            Reporter: Kenji Matsuoka
>
> This code, at JobClient:306, doesn't seem to do validate the fully qualified inputDirs,
since inputDirs is a newly created arrray:
>         Path[] inputDirs = job.getInputPaths();
>  
>         // make sure directories are fully qualified before checking them
>         for(int i=0; i < inputDirs.length; ++i) {
>           if (inputDirs[i].toUri().getScheme() == null) {
>             inputDirs[i] = userFileSys.makeQualified(inputDirs[i]);
>           }
>         }
>         // input paths should exist. 
>         job.getInputFormat().validateInput(job);

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message