Return-Path: Delivered-To: apmail-lucene-hadoop-dev-archive@locus.apache.org Received: (qmail 4784 invoked from network); 8 Dec 2006 00:38:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Dec 2006 00:38:45 -0000 Received: (qmail 16549 invoked by uid 500); 8 Dec 2006 00:38:52 -0000 Delivered-To: apmail-lucene-hadoop-dev-archive@lucene.apache.org Received: (qmail 16400 invoked by uid 500); 8 Dec 2006 00:38:52 -0000 Mailing-List: contact hadoop-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hadoop-dev@lucene.apache.org Delivered-To: mailing list hadoop-dev@lucene.apache.org Received: (qmail 16391 invoked by uid 99); 8 Dec 2006 00:38:51 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Dec 2006 16:38:51 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Dec 2006 16:38:42 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id B69D97142FB for ; Thu, 7 Dec 2006 16:38:22 -0800 (PST) Message-ID: <11180679.1165538302745.JavaMail.jira@brutus> Date: Thu, 7 Dec 2006 16:38:22 -0800 (PST) From: "Raghu Angadi (JIRA)" To: hadoop-dev@lucene.apache.org Subject: [jira] Commented: (HADOOP-764) The memory consumption of processReport() in the namenode can be reduced In-Reply-To: <21824491.1164845001071.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/HADOOP-764?page=comments#action_12456652 ] Raghu Angadi commented on HADOOP-764: ------------------------------------- Yes, I was going to comment saying the patch should be applied. > The memory consumption of processReport() in the namenode can be reduced > ------------------------------------------------------------------------ > > Key: HADOOP-764 > URL: http://issues.apache.org/jira/browse/HADOOP-764 > Project: Hadoop > Issue Type: Bug > Components: dfs > Reporter: dhruba borthakur > Assigned To: dhruba borthakur > Attachments: processBlockReport3.patch > > > The FSNamesystem.processReport() method converts the blocklist for a datanode into an array by calling node.getBlocks(). Although this memory allocation is transient, it could possibly require the garbage-collector to work that much harder. > The method Block.getBlocks() should be deprecated. Code that currently uses this method should instead iterate over the Collection. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira